Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup warnings #2138

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Fixup warnings #2138

merged 3 commits into from
Oct 3, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Oct 3, 2023

This fixes up three warnings:

  • Wrong format specifier in the embedded shell.
  • Using abs instead of std::abs in our arithmetic functions.
  • Exporting types in our c_api.

Exporting structs only makes sense in C++, and only when there are methods to export (or typeinfo). Neither of those is true here.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ede12a7) 89.63% compared to head (0b8cb7a) 89.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2138   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         988      988           
  Lines       35729    35729           
=======================================
+ Hits        32024    32026    +2     
+ Misses       3705     3703    -2     
Files Coverage Δ
...include/function/arithmetic/arithmetic_functions.h 93.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku merged commit 851b567 into master Oct 3, 2023
11 checks passed
@Riolku Riolku deleted the fixup-warnings branch October 3, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants