Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function exports/imports for inlined Value functions #2134

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Being inline, they don't need library symbols, and dllimport on windows isn't allowed for inline functions since there would be nothing to import.

Should fix CI again I think.

Being inline, they don't need library symbols, and dllimport on windows isn't allowed for inline functions since there would be nothing to import
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7308523) 89.63% compared to head (97d40b4) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
+ Coverage   89.63%   89.66%   +0.03%     
==========================================
  Files         988      988              
  Lines       35729    35729              
==========================================
+ Hits        32024    32036      +12     
+ Misses       3705     3693      -12     
Files Coverage Δ
src/include/common/types/value/value.h 90.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 0a86247 into master Oct 2, 2023
11 checks passed
@ray6080 ray6080 deleted the value-template-fix branch October 2, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants