Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-bundled rust build #2133

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix non-bundled rust build #2133

merged 1 commit into from
Oct 2, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Only set KUZU_STATIC_DEFINE in the rust build if linking statically. If linking dynamically against the release binaries it should use the default "import" mode for the headers. It should also be possible to link against a pre-built static library, which this also preserves support for.

We're not testing the non-bundled build at the moment, so that's something that could be added to the list of things to test when setting up the other tests of the single file headers.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7308523) 89.63% compared to head (9bb90ae) 89.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2133   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         988      988           
  Lines       35729    35729           
=======================================
+ Hits        32024    32027    +3     
+ Misses       3705     3702    -3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 119813d into master Oct 2, 2023
10 of 11 checks passed
@ray6080 ray6080 deleted the rust-non-bundled-fix branch October 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants