Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve recursive join projection #2132

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Oct 2, 2023

This PR further improves projection push down

On LDBC100

With Projection 471.9 ms

MATCH (a:Person)-[e:Knows*1..3]->(b:Person) 
WHERE a.ID = 933
RETURN properties(nodes(e), 'firstName');

Without Projection 3412.8 ms

MATCH (a:Person)-[e:Knows*1..3 (r, n | {}, {n.firstName})]->(b:Person) 
WHERE a.ID = 933
RETURN properties(nodes(e), 'firstName');

@ray6080 ray6080 force-pushed the recursive-join-projection-improvement branch from e914f95 to 9d97a17 Compare October 2, 2023 07:56
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f28f3d3) 89.63% compared to head (9d97a17) 89.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2132      +/-   ##
==========================================
- Coverage   89.63%   89.63%   -0.01%     
==========================================
  Files         988      988              
  Lines       35653    35717      +64     
==========================================
+ Hits        31959    32015      +56     
- Misses       3694     3702       +8     
Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 94.72% <100.00%> (+0.04%) ⬆️
...c/include/parser/query/graph_pattern/rel_pattern.h 100.00% <100.00%> (ø)
...planner/operator/extend/logical_recursive_extend.h 96.00% <100.00%> (ø)
...essor/operator/recursive_extend/frontier_scanner.h 100.00% <100.00%> (ø)
...ocessor/operator/recursive_extend/recursive_join.h 100.00% <100.00%> (ø)
src/optimizer/acc_hash_join_optimizer.cpp 98.26% <100.00%> (+0.04%) ⬆️
src/optimizer/projection_push_down_optimizer.cpp 99.39% <ø> (+0.59%) ⬆️
src/parser/transform/transform_graph_pattern.cpp 94.39% <100.00%> (+0.39%) ⬆️
...anner/operator/extend/logical_recursive_extend.cpp 100.00% <100.00%> (ø)
src/planner/plan/append_extend.cpp 96.66% <100.00%> (+0.11%) ⬆️
... and 6 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit f1f7b75 into master Oct 2, 2023
10 of 11 checks passed
@ray6080 ray6080 deleted the recursive-join-projection-improvement branch October 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants