Ignore imports and exports in the static rust build #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 89.61% 89.64% +0.02%
==========================================
Files 988 988
Lines 35644 35653 +9
==========================================
+ Hits 31944 31960 +16
+ Misses 3700 3693 -7 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Oct 2, 2023
benjaminwinger
force-pushed
the
rust-build-fix
branch
from
b93bf95
to
d299936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the rust build failure. The rust build can ignore the imports/exports since it's not using the shared library, but without the define the rust shim is treated as third-party software importing the headers for use with the shared library.