Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update begin trasaction syntax #2126

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Oct 1, 2023

BEGIN READ TRANSACTION -> BEGIN TRANSACTION READ ONLY
BEGIN WRITE TRANSACTION -> BEGIN TRANSACTION

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (850f506) 89.62% compared to head (353ecef) 89.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   89.62%   89.65%   +0.02%     
==========================================
  Files         988      988              
  Lines       35653    35653              
==========================================
+ Hits        31954    31963       +9     
+ Misses       3699     3690       -9     
Files Coverage Δ
src/main/connection.cpp 92.53% <100.00%> (ø)
src/parser/transform/transform_transaction.cpp 87.50% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit f28f3d3 into master Oct 2, 2023
10 of 11 checks passed
@andyfengHKU andyfengHKU deleted the fix-transaction-syntax branch October 2, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants