Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reader/csv: Use binary mode on Windows #2121

Merged
merged 1 commit into from
Sep 30, 2023
Merged

reader/csv: Use binary mode on Windows #2121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/processor/operator/persistent/reader/csv/base_csv_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ BaseCSVReader::BaseCSVReader(const std::string& filePath, const common::ReaderCo
buffer(nullptr), bufferSize(0), position(0), rowEmpty(false), mode(ParserMode::INVALID),
rowToAdd(0) {
// TODO(Ziyi): should we wrap this fd using kuzu file handler?
fd = open(filePath.c_str(), O_RDONLY);
fd = open(filePath.c_str(), O_RDONLY
#ifdef _WIN32
| _O_BINARY
#endif
);
if (fd == -1) {
throw CopyException(
StringUtils::string_format("Could not open file {}: {}", filePath, strerror(errno)));
Expand Down