Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish cast to bool #2119

Merged
merged 1 commit into from
Sep 30, 2023
Merged

finish cast to bool #2119

merged 1 commit into from
Sep 30, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Sep 29, 2023

  • refactor code
  • changed function name to_xxx
  • add cast to bool

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9f2b790) 89.77% compared to head (9f3ddf7) 89.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2119      +/-   ##
==========================================
+ Coverage   89.77%   89.78%   +0.01%     
==========================================
  Files         988      988              
  Lines       35661    35624      -37     
==========================================
- Hits        32013    31986      -27     
+ Misses       3648     3638      -10     
Files Coverage Δ
src/common/type_utils.cpp 59.25% <ø> (-0.75%) ⬇️
src/function/built_in_vector_functions.cpp 99.46% <100.00%> (+<0.01%) ⬆️
src/include/common/type_utils.h 100.00% <ø> (ø)
src/include/function/cast/cast_functions.h 97.29% <100.00%> (-1.73%) ⬇️
src/include/function/cast/vector_cast_functions.h 95.65% <100.00%> (+0.78%) ⬆️
...rocessor/operator/persistent/reader/csv/driver.cpp 94.16% <100.00%> (ø)
src/storage/store/table_copy_utils.cpp 96.87% <ø> (ø)
src/function/vector_cast_functions.cpp 78.83% <97.36%> (-6.45%) ⬇️
src/include/function/cast/numeric_cast.h 84.84% <93.93%> (+4.54%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test_files/tinysnb/function/cast.test Show resolved Hide resolved
test/test_files/tinysnb/function/cast.test Outdated Show resolved Hide resolved
test/test_files/tinysnb/agg/multi_query_part.test Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Show resolved Hide resolved
@acquamarin acquamarin merged commit db85850 into master Sep 30, 2023
10 of 11 checks passed
@acquamarin acquamarin deleted the cast branch September 30, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants