reader/csv: sniff column name and type #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
sniff-header
branch
4 times, most recently
from
9097cb8
to
c8ec87e
Compare
acquamarin
approved these changes
Sep 29, 2023
| readerConfig->columnTypes.push_back(stringType.copy()); | ||
| columns.push_back(createVariable(columnName, stringType)); | ||
| readerConfig->columnTypes.push_back(std::move(columnType)); | ||
| columns.push_back(createVariable(columnName, columnTypeID)); |
There was a problem hiding this comment.
You don't need to create a variable for columnTypeID since it is only used once. Just inline the call
| void addRow(common::DataChunk&, common::column_id_t column); | ||
|
|
||
| template<typename Driver> | ||
| bool addRow(Driver&, uint64_t rowNum, common::column_id_t column_count); |
There was a problem hiding this comment.
Add a variable name for Driver&
| return; | ||
| } | ||
| template<typename Driver> | ||
| bool BaseCSVReader::addRow(Driver& driver, uint64_t rowNum, column_id_t column) { |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
- Coverage 89.78% 89.76% -0.03%
==========================================
Files 986 988 +2
Lines 35563 35596 +33
==========================================
+ Hits 31932 31953 +21
- Misses 3631 3643 +12
☔ View full report in Codecov by Sentry. |
The format is `COLUMN_NAME:COLUMN_TYPE`. As part of this change, the CSV reader module has been refactored to use "Drivers" for the actual storing of the values. This allows easy implementation of sniffing, header skipping, and parsing, without affecting performance (because it's all compile time) and it also keeps the reader code clean.
andyfengHKU
force-pushed
the
sniff-header
branch
from
c8ec87e
to
5121c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format is
COLUMN_NAME:COLUMN_TYPE.