Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow check for casting #2114

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add overflow check for casting #2114

merged 1 commit into from
Sep 29, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c4652f2) 89.78% compared to head (81f77b7) 89.76%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2114      +/-   ##
==========================================
- Coverage   89.78%   89.76%   -0.03%     
==========================================
  Files         986      986              
  Lines       35626    35559      -67     
==========================================
- Hits        31987    31919      -68     
- Misses       3639     3640       +1     
Files Coverage Δ
src/function/vector_cast_functions.cpp 85.28% <100.00%> (+0.22%) ⬆️
src/include/function/cast/numeric_cast.h 80.30% <100.00%> (+4.83%) ⬆️
...operator/persistent/reader/csv/base_csv_reader.cpp 96.05% <100.00%> (ø)
tools/java_api/src/jni/kuzu_java.cpp 80.29% <100.00%> (ø)
src/include/function/cast/cast_functions.h 99.01% <95.00%> (-0.99%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit bc74559 into master Sep 29, 2023
10 of 11 checks passed
@acquamarin acquamarin deleted the cast-fix branch September 29, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants