Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slot capacity #2111

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Change slot capacity #2111

merged 1 commit into from
Sep 29, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Sep 29, 2023

On LDBC100 comment table, this can decrease index file size from ~7.6GB to ~5.7GB. Also reduced the end to end copy time by around 10% on UW5 under default setting.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53d91db) 89.63% compared to head (409d5ca) 89.83%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   89.63%   89.83%   +0.20%     
==========================================
  Files         985      985              
  Lines       35750    35460     -290     
==========================================
- Hits        32043    31855     -188     
+ Misses       3707     3605     -102     
Files Coverage Δ
src/include/storage/index/hash_index.h 94.87% <ø> (-0.13%) ⬇️
src/include/storage/index/hash_index_builder.h 79.06% <ø> (ø)
src/include/storage/index/hash_index_slot.h 87.50% <ø> (ø)
src/include/storage/storage_info.h 100.00% <100.00%> (ø)
src/storage/index/hash_index.cpp 97.55% <100.00%> (-0.42%) ⬇️
src/storage/index/hash_index_builder.cpp 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 815580a into master Sep 29, 2023
10 of 11 checks passed
@andyfengHKU andyfengHKU deleted the hash-index-profile branch September 29, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants