Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add numerical types for APIs #2105

Merged
merged 2 commits into from
Sep 29, 2023
Merged

add numerical types for APIs #2105

merged 2 commits into from
Sep 29, 2023

Conversation

Ashleyhx
Copy link
Contributor

@Ashleyhx Ashleyhx commented Sep 28, 2023

support reading new dataTypes in all supported dataTypes

@Ashleyhx Ashleyhx changed the title add for java api add numerical types for APIs Sep 28, 2023
@Ashleyhx Ashleyhx requested a review from mewim September 28, 2023 15:44
@Ashleyhx
Copy link
Contributor Author

@benjaminwinger could you take a look at my rust part, I have added the other int types to rust and it can pass all test.

@benjaminwinger
Copy link
Collaborator

The rust part looks good to me

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9cc01df) 89.02% compared to head (cbb7cfc) 89.86%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   89.02%   89.86%   +0.83%     
==========================================
  Files         981      985       +4     
  Lines       36068    35516     -552     
==========================================
- Hits        32110    31916     -194     
+ Misses       3958     3600     -358     
Files Coverage Δ
src/c_api/prepared_statement.cpp 100.00% <100.00%> (ø)
src/c_api/value.cpp 88.46% <100.00%> (+1.50%) ⬆️
tools/java_api/src/jni/kuzu_java.cpp 80.29% <100.00%> (+0.43%) ⬆️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashleyhx Ashleyhx marked this pull request as ready for review September 29, 2023 14:37
Copy link
Collaborator

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ashleyhx Ashleyhx merged commit 2219d40 into master Sep 29, 2023
10 of 11 checks passed
@Ashleyhx Ashleyhx deleted the add-intType-api branch September 29, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants