Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up arrow code in node column chunk and copy node #2104

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Sep 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e110344) 88.99% compared to head (b608e09) 89.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
+ Coverage   88.99%   89.57%   +0.58%     
==========================================
  Files         981      981              
  Lines       36067    35827     -240     
==========================================
- Hits        32097    32093       -4     
+ Misses       3970     3734     -236     
Files Coverage Δ
src/include/storage/store/column_chunk.h 92.00% <ø> (+3.53%) ⬆️
src/include/storage/store/string_column_chunk.h 100.00% <ø> (ø)
src/include/storage/store/var_list_column_chunk.h 83.33% <ø> (+52.08%) ⬆️
src/processor/operator/persistent/copy_node.cpp 95.20% <100.00%> (+1.87%) ⬆️
src/storage/store/column_chunk.cpp 75.88% <100.00%> (+22.28%) ⬆️
src/storage/store/string_column_chunk.cpp 60.97% <ø> (+17.49%) ⬆️
src/storage/store/struct_column_chunk.cpp 28.04% <ø> (+9.19%) ⬆️
src/storage/store/var_list_column_chunk.cpp 79.62% <ø> (+28.43%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit f05d348 into master Sep 28, 2023
11 checks passed
@ray6080 ray6080 deleted the clean-arrow branch September 28, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants