Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add-prop #2100

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix add-prop #2100

merged 1 commit into from
Sep 28, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a21e52d) 88.91% compared to head (926ad4a) 88.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         979      979           
  Lines       36082    36083    +1     
=======================================
+ Hits        32082    32084    +2     
+ Misses       4000     3999    -1     
Files Coverage Δ
src/function/vector_list_functions.cpp 90.18% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if this also fix #1954

@acquamarin acquamarin merged commit 9cc01df into master Sep 28, 2023
11 checks passed
@acquamarin acquamarin deleted the add-prop branch September 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants