upload benchmark copy query times to benchmark server

[russell-liu]

No description provided.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a21e52d) 88.91% compared to head (fb666af) 89.60%.
Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2099      +/-   ##
==========================================
+ Coverage   88.91%   89.60%   +0.68%     
==========================================
  Files         979      985       +6     
  Lines       36082    35750     -332     
==========================================
- Hits        32082    32032      -50     
+ Misses       4000     3718     -282     

Files	Coverage Δ
src/include/storage/storage_info.h	100.00% <100.00%> (ø)

... and 56 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mewim]

You should consider move this out of the for loop. You should not need to reopen the file each time.

[mewim]

Try to switch to sys.stdout.write and sys.stdout.flush to see if it solves the out of order issue

[russell-liu]

Working now at: https://benchmark.kuzudb.com/run.html#2411

[mewim]

This logic is not very readable.

1. You should run the check for create statement before subprocess.Popen. If it is a create you should simply pass the output via sys.stdout and sys.stderr redirection instead of manually get the output and print.
2. Instead of setting match to False here you should indent line 66-75 so it is under your else. If you do this, you can also avoid the if check for your write and flush.
3. Do not reuse your flags. Call it create_match and copy_match maybe. Reusing a flag-type variable is
   error-prone and make the code hard to understand.

[mewim]

Code LGTM now. It should be merged after another round of end-to-end test.