Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ALTER statement #2097

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Refactor ALTER statement #2097

merged 1 commit into from
Sep 27, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR removes the distinction between RENAME_TABLE, ADD_PROPERTY, DROP_PROPERTY and RENAME_PROPERTY and treat them as ALTER at statement, bound statement and logical operator level.

Removing distinction at physical operator level should also be possible but needs more change.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e28a3c8) 88.93% compared to head (acaf975) 88.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         987      979    -8     
  Lines       36127    36082   -45     
=======================================
- Hits        32128    32091   -37     
+ Misses       3999     3991    -8     
Files Coverage Δ
src/binder/binder.cpp 95.23% <100.00%> (-0.32%) ⬇️
src/binder/bound_statement_visitor.cpp 93.54% <100.00%> (-0.40%) ⬇️
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/binder/bound_statement_visitor.h 50.00% <100.00%> (-4.55%) ⬇️
src/include/binder/ddl/bound_alter.h 100.00% <100.00%> (ø)
src/include/binder/ddl/bound_alter_info.h 100.00% <100.00%> (ø)
src/include/binder/ddl/bound_create_table.h 100.00% <100.00%> (ø)
src/include/binder/ddl/bound_drop_table.h 100.00% <100.00%> (ø)
...ude/binder/visitor/statement_read_write_analyzer.h 100.00% <100.00%> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
... and 14 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit a21e52d into master Sep 27, 2023
11 checks passed
@ray6080 ray6080 deleted the unify-alter-ddl branch September 27, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants