Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning #2094

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix warning #2094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/function/table_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@
case TableType::RDF: {
typeString = "RDF";
} break;
default: {
throw common::NotImplementedException{"ShowTablesFunction::tableFunc"};

Check warning on line 120 in src/function/table_functions.cpp

View check run for this annotation

Codecov / codecov/patch

src/function/table_functions.cpp#L119-L120 

Added lines #L119 - L120 were not covered by tests
}
};
outputVectors[1]->setValue(i, typeString);
outputVectors[2]->setValue(i, tableSchema->comment);
Expand Down
7 changes: 7 additions & 0 deletions third_party/miniparquet/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ if(POLICY CMP0063)
cmake_policy(SET CMP0063 NEW)
endif()

# Certain Clang compiler versions throw "deprecated declarations" warnings for
# Thrift.h which comes from the Apache thrift library.
# The workaround, for now, is to disable this warning if the compiler is Clang.
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-deprecated-declarations)
endif()

project(miniparquet CXX)

include_directories(src/parquet
Expand Down
12 changes: 12 additions & 0 deletions third_party/miniparquet/src/parquet/parquet_types.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.