Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add castString in functions #2092

Merged
merged 1 commit into from
Sep 29, 2023
Merged

add castString in functions #2092

merged 1 commit into from
Sep 29, 2023

Conversation

AEsir777
Copy link
Contributor

@AEsir777 AEsir777 commented Sep 26, 2023

  • fix signed int type downcast (to do: unsigned int type downcast + wrapper function (leave to next PR))
  • changed string cast to function std::from_chars
  • changed all occurrences of stringCastUtils to use the kuzu functions

To Do:

  • fix all the typos
  • add test cases

src/common/types/ku_string.cpp Outdated Show resolved Hide resolved
src/include/common/types/ku_string.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
test/test_files/tinysnb/function/cast.test Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (d4b0f19) 89.83% compared to head (7b1af69) 89.81%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   89.83%   89.81%   -0.03%     
==========================================
  Files         985      986       +1     
  Lines       35461    35626     +165     
==========================================
+ Hits        31858    31998     +140     
- Misses       3603     3628      +25     
Files Coverage Δ
src/common/string_utils.cpp 97.61% <100.00%> (+0.47%) ⬆️
src/function/vector_cast_functions.cpp 85.05% <100.00%> (+0.91%) ⬆️
src/include/common/string_utils.h 91.66% <ø> (ø)
src/include/common/type_utils.h 100.00% <ø> (+2.56%) ⬆️
src/include/function/cast/cast_functions.h 100.00% <100.00%> (+0.68%) ⬆️
...age/in_mem_storage_structure/in_mem_column_chunk.h 72.72% <ø> (ø)
src/parser/transform/transform_expression.cpp 97.37% <100.00%> (+<0.01%) ⬆️
...operator/persistent/reader/csv/base_csv_reader.cpp 96.05% <100.00%> (-0.13%) ⬇️
.../storage/in_mem_storage_structure/in_mem_lists.cpp 68.09% <ø> (ø)
src/storage/store/table_copy_utils.cpp 96.87% <ø> (ø)
... and 2 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/common/types/ku_string.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/common/types/ku_string.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_functions.h Outdated Show resolved Hide resolved
src/include/function/cast/numeric_cast.h Outdated Show resolved Hide resolved
src/include/function/cast/numeric_cast.h Outdated Show resolved Hide resolved
src/include/common/string_utils.h Outdated Show resolved Hide resolved
src/common/string_utils.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Riolku Riolku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AEsir777 AEsir777 merged commit c4652f2 into master Sep 29, 2023
10 of 11 checks passed
@AEsir777 AEsir777 deleted the cast branch September 29, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants