Database access mode #2089
Merged
Database access mode #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
reviewed
Sep 26, 2023
src/include/common/file_utils.h
Outdated
| @@ -15,6 +15,24 @@ | |||
| namespace kuzu { | |||
| namespace common { | |||
|
|
|||
| enum class FileLockType : uint8_t { NO_LOCK = 0, READ_LOCK = 1, WRITE_LOCK = 2 }; | |||
|
|
|||
| class FileFlags { | |||
There was a problem hiding this comment.
This class should be cleaned after you merge locking logic into existing openFile function.
hououou
force-pushed
the
access_mode
branch
2 times, most recently
from
6ba2181
to
70223a4
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2089 +/- ##
==========================================
+ Coverage 89.55% 89.58% +0.02%
==========================================
Files 1007 1006 -1
Lines 36250 36273 +23
==========================================
+ Hits 32465 32496 +31
+ Misses 3785 3777 -8
☔ View full report in Codecov by Sentry. |
hououou
commented
Sep 28, 2023
ray6080
requested changes
Sep 28, 2023
ray6080
requested changes
Sep 28, 2023
hououou
force-pushed
the
access_mode
branch
from
f5554d9
to
ccbcab0
Compare
ray6080
force-pushed
the
access_mode
branch
from
376f252
to
4762664
Compare
acquamarin
force-pushed
the
access_mode
branch
2 times, most recently
from
3d30627
to
3660a9c
Compare
acquamarin
force-pushed
the
access_mode
branch
from
3660a9c
to
392d4a9
Compare
ray6080
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at solving issue #921 on non-Windows platforms.
Steps:
.lockin each database directory. Use this file to check the status of the database.READ_ONLYorREAD_WRITE(note I useREAD_WRITEwhen the access mode is not specified), lock the.lockusing the functionfcntl.Limitation
fcntlcan only solve the read-write lock during different processes. So we cannot solve the read-write lock in the same process.