Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrow from npy reader #2086

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Remove arrow from npy reader #2086

merged 1 commit into from
Sep 26, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4628776) 89.01% compared to head (0f20e31) 88.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   89.01%   88.91%   -0.11%     
==========================================
  Files         987      987              
  Lines       36057    36036      -21     
==========================================
- Hits        32097    32042      -55     
- Misses       3960     3994      +34     
Files Coverage Δ
src/binder/bind/bind_copy.cpp 91.66% <100.00%> (+0.27%) ⬆️
.../processor/operator/persistent/reader/npy_reader.h 100.00% <ø> (ø)
src/include/storage/store/column_chunk.h 88.46% <100.00%> (+0.22%) ⬆️
...ssor/operator/persistent/reader/npy/npy_reader.cpp 77.88% <100.00%> (-3.04%) ⬇️
...processor/operator/persistent/reader_functions.cpp 86.66% <100.00%> (-0.27%) ⬇️
src/processor/operator/persistent/reader_state.cpp 100.00% <ø> (ø)
src/storage/store/column_chunk.cpp 55.83% <100.00%> (-8.94%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 5cbb422 into master Sep 26, 2023
11 checks passed
@acquamarin acquamarin deleted the npy-reader branch September 26, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants