-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parquet-reader #2076
Implement parquet-reader #2076
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 90.21% 89.00% -1.22%
==========================================
Files 966 987 +21
Lines 35019 36057 +1038
==========================================
+ Hits 31593 32092 +499
- Misses 3426 3965 +539
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I didn't really get into details for this PR. Only peeked into parts our ValueVector gets used. It's hard to figure out the whole logic right away, but I feel we can trust a bit on duck's code path.
One high level comment: we should try to improve the codecov for this PR by two options: 1) guard code path not enabled at all with LCOV_EXEC_START
and LCOV_EXEC_STOP
, for example: prefetch mode; 2) see if there are easy cases we can add tests, maybe the following code block?
if (thisOutputChunkRows == 0) {1
--
+ state.finished = true;
+ return false; // end of last group, we are done
+ }
src/processor/operator/persistent/reader/parquet/struct_column_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/parquet/parquet_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/parquet/parquet_reader.cpp
Outdated
Show resolved
Hide resolved
src/include/processor/operator/persistent/reader/parquet/parquet_reader.h
Show resolved
Hide resolved
c2b1865
to
c905762
Compare
c905762
to
b43a63c
Compare
No description provided.