Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename logicalScanNode to logicalScanInternalID #2067

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

andyfengHKU
Copy link
Contributor

Rename LogicalScanNode to LogicalScanInternalID, remove node expression from logical operator and replace with internal ID expression + table IDs.

The new design is more semantically accurate because we are not scanning from storage at all. So calling it ScanNode is misleading. Also, as RDF processing comes in, the same operator will be used to scan predicate ID which is no longer a node under RDF setup.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 99.00% and project coverage change: -0.01% ⚠️

Comparison is base (f8d48a6) 90.20% compared to head (c075690) 90.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   90.20%   90.20%   -0.01%     
==========================================
  Files         953      953              
  Lines       34582    34592      +10     
==========================================
+ Hits        31194    31202       +8     
- Misses       3388     3390       +2     
Files Changed Coverage Δ
src/include/optimizer/acc_hash_join_optimizer.h 100.00% <ø> (ø)
src/include/optimizer/filter_push_down_optimizer.h 100.00% <ø> (ø)
src/include/planner/operator/logical_operator.h 90.00% <ø> (ø)
src/include/planner/operator/logical_plan_util.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/planner/operator/logical_operator.cpp 82.43% <50.00%> (ø)
src/include/optimizer/logical_operator_collector.h 91.66% <83.33%> (ø)
src/binder/bind/bind_graph_pattern.cpp 96.33% <100.00%> (ø)
src/binder/bind/bind_projection_clause.cpp 93.38% <100.00%> (ø)
... and 45 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit bb02646 into master Sep 21, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the remove-node-expression-from-logical-scan-node branch September 21, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants