Rename logicalScanNode to logicalScanInternalID #2067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename LogicalScanNode to LogicalScanInternalID, remove node expression from logical operator and replace with internal ID expression + table IDs.
The new design is more semantically accurate because we are not scanning from storage at all. So calling it ScanNode is misleading. Also, as RDF processing comes in, the same operator will be used to scan predicate ID which is no longer a node under RDF setup.