Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different schema for each RecordBatch in python getAsArrow #2055

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Fixes #2037.

I also bumped the version of pyarrow used in CI so that the new memory release check that was catching this issue gets used in CI.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (fe850a7) 90.22% compared to head (6cc9364) 90.24%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         950      950              
  Lines       33776    33779       +3     
==========================================
+ Hits        30476    30484       +8     
+ Misses       3300     3295       -5     
Files Changed Coverage Δ
tools/python_api/src_cpp/include/py_query_result.h 100.00% <ø> (ø)
tools/python_api/src_cpp/py_query_result.cpp 96.15% <100.00%> (-0.05%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 6943574 into master Sep 19, 2023
11 checks passed
@benjaminwinger benjaminwinger deleted the python-arrow-fix branch September 19, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python get_as_arrow api error
2 participants