Refactor node table to take in columnID instead of propertyID #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
force-pushed
the
refactor-storage
branch
from
b21f97d
to
8c1f30c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.01%
==========================================
Files 950 950
Lines 33776 33781 +5
==========================================
+ Hits 30476 30486 +10
+ Misses 3300 3295 -5
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Sep 19, 2023
| @@ -50,6 +49,16 @@ property_id_t TableSchema::getPropertyID(const std::string& propertyName) const | |||
| "Table: {} doesn't have a property with propertyName={}.", tableName, propertyName)); | |||
| } | |||
|
|
|||
| // TODO(Guodong): Instead of looping over properties, cache a map between propertyID and columnID. | |||
There was a problem hiding this comment.
Yes let's open an issue about this
ray6080
force-pushed
the
refactor-storage
branch
from
8c1f30c
to
2c20885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now node table takes in columnID instead propertyID to access a column. Internally node table stores all columns in a vector (instead of a map), which is aligned with its tableSchema (we skip INTERNAL_ID column).
The front-end (or mapper currently) is responsible for aligning scanned columns in node table with properties in schema.