Rewrite transaction test #2053
Merged
Rewrite transaction test #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 950 950
Lines 33776 33776
==========================================
+ Hits 30478 30482 +4
+ Misses 3298 3294 -4 ☔ View full report in Codecov by Sentry. |
andyfengHKU
reviewed
Sep 19, 2023
test/test_files/transaction/create_rel/insert_rels_to_small_list.test
Outdated
Show resolved
Hide resolved
| @@ -5,6 +5,7 @@ | |||
| #include "common/exception/test.h" | |||
| #include "common/string_utils.h" | |||
| #include "spdlog/spdlog.h" | |||
| #include "test_helper/test_helper.h" | |||
There was a problem hiding this comment.
this must be a duplicate include
There was a problem hiding this comment.
it needs to be included
ray6080
approved these changes
Sep 19, 2023
test/test_files/transaction/delete_rel/delete_rels_from_one_to_one_table.test
Outdated
Show resolved
Hide resolved
test/test_files/transaction/update_rel/insertAndUpdate_rels_for_newly_added_node.test
Outdated
Show resolved
Hide resolved
test/test_files/transaction/create_rel/insert_rels_to_different_nodes.test
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read and agree to the terms under CLA.md.
I have made the following changes:
Expand multiple connections to support default connection if not create connection previously
-use case:
-CREATE_CONNECTION conn_write
-STATEMENT [conn_write] BEGIN WRITE TRANSACTION
---- ok
-STATEMENT BEGIN READ TRANSACTION
---- ok
Expand the test framework to support batch statements; the file is loaded from KUZU_ROOT_PATH/test/statements
-use case:
-BATCH_STATEMENTS <FILE>:xx.cypher
---- ok
Rewrite the following tests to test_file