Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load from csv #2052

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Load from csv #2052

merged 1 commit into from
Sep 21, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Sep 19, 2023

This PR implements the initial version of direct scan of CSV file.

We don't detect header name or data type. All columns are scanned as "columnN" with data type STRING.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: +0.03% 🎉

Comparison is base (f59d9a8) 90.09% compared to head (d9ef4a8) 90.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   90.09%   90.12%   +0.03%     
==========================================
  Files         950      952       +2     
  Lines       34455    34516      +61     
==========================================
+ Hits        31042    31109      +67     
+ Misses       3413     3407       -6     
Files Changed Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
src/include/planner/query_planner.h 100.00% <ø> (ø)
...lude/binder/query/reading_clause/bound_load_from.h 33.33% <33.33%> (ø)
src/binder/bind/bind_reading_clause.cpp 94.36% <90.90%> (-1.56%) ⬇️
src/binder/bind/bind_copy.cpp 92.05% <100.00%> (ø)
src/binder/bound_statement_visitor.cpp 93.93% <100.00%> (+0.18%) ⬆️
src/include/binder/bound_statement_visitor.h 59.09% <100.00%> (+1.94%) ⬆️
src/include/binder/copy/bound_file_scan_info.h 100.00% <100.00%> (ø)
...rc/include/parser/query/reading_clause/load_from.h 100.00% <100.00%> (ø)
... and 11 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/bind/bind_reading_clause.cpp Outdated Show resolved Hide resolved
src/planner/plan/plan_read.cpp Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit a92f0fb into master Sep 21, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the load-from-csv branch September 21, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants