Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reader functors #2049

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Refactor reader functors #2049

merged 1 commit into from
Sep 18, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Sep 18, 2023

This PR removes table schema from reader operator and reader functors. This is because as we implement direct scan from file, we don't have a notion of table schema anymore.

The information being exposed to all reader classes are

 struct ReaderConfig {
     FileType fileType = FileType::UNKNOWN;
     std::vector<std::string> filePaths;
     std::vector<std::string> columnNames;
     std::vector<std::unique_ptr<common::LogicalType>> columnTypes;
     std::unique_ptr<CSVReaderConfig> csvReaderConfig = nullptr;

src/binder/bind/bind_copy.cpp Outdated Show resolved Hide resolved
src/include/processor/operator/persistent/copy_node.h Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 97.52% and project coverage change: -0.03% ⚠️

Comparison is base (9ff7a2a) 90.26% compared to head (88f68a3) 90.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
- Coverage   90.26%   90.23%   -0.03%     
==========================================
  Files         950      950              
  Lines       33811    33776      -35     
==========================================
- Hits        30520    30479      -41     
- Misses       3291     3297       +6     
Files Changed Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
.../processor/operator/persistent/reader/csv_reader.h 100.00% <ø> (ø)
src/include/storage/copier/column_chunk.h 94.11% <ø> (ø)
src/include/storage/copier/npy_reader.h 100.00% <ø> (ø)
src/include/storage/copier/table_copy_utils.h 100.00% <ø> (ø)
src/storage/copier/npy_reader.cpp 82.44% <20.00%> (ø)
src/processor/map/map_copy_from.cpp 98.82% <87.50%> (-1.18%) ⬇️
src/binder/bind/bind_copy.cpp 91.89% <100.00%> (+0.78%) ⬆️
src/binder/bind/bind_file_scan.cpp 81.25% <100.00%> (-1.61%) ⬇️
src/common/copier_config/copier_config.cpp 80.00% <100.00%> (ø)
... and 18 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit fea82f6 into master Sep 18, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the remove-schema-from-reader branch September 18, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants