Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CopyDescription with CSVReaderConfig for storage classes. #2046

Merged

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Sep 18, 2023

We are storing copyDescription* in many storage classes. This is bad because

  • life cycle is not guaranteed.
  • logic itself should be handled at reader level instead of propagating to storage.

I'm refactoring copyDescription and it touches quite a lot of files. I'm splitting refactor into multiple PRs.

In this PR we replace all copyDescription* with unique_ptr

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 93.93% and project coverage change: -0.02% ⚠️

Comparison is base (2e460d6) 90.20% compared to head (79f0c5a) 90.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   90.20%   90.19%   -0.02%     
==========================================
  Files         945      945              
  Lines       33549    33558       +9     
==========================================
+ Hits        30262    30266       +4     
- Misses       3287     3292       +5     
Files Changed Coverage Δ
src/include/storage/copier/node_group.h 100.00% <ø> (ø)
src/include/storage/copier/string_column_chunk.h 100.00% <ø> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 72.72% <ø> (ø)
src/storage/copier/var_list_column_chunk.cpp 80.95% <66.66%> (+0.22%) ⬆️
src/storage/copier/struct_column_chunk.cpp 33.05% <80.00%> (+0.57%) ⬆️
src/storage/copier/column_chunk.cpp 75.48% <90.90%> (-0.24%) ⬇️
src/include/common/copier_config/copier_config.h 100.00% <100.00%> (ø)
.../include/processor/operator/persistent/copy_node.h 100.00% <100.00%> (ø)
src/include/storage/copier/column_chunk.h 94.11% <100.00%> (+0.11%) ⬆️
src/include/storage/copier/var_list_column_chunk.h 100.00% <100.00%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 1c63a71 into master Sep 18, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the replace-copy-description-with-csv-reader-config-in-storage branch September 18, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants