Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unsigned int types #2045

Merged
merged 1 commit into from
Sep 20, 2023
Merged

add unsigned int types #2045

merged 1 commit into from
Sep 20, 2023

Conversation

Ashleyhx
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 83.74% and project coverage change: -0.14% ⚠️

Comparison is base (7bf0d6e) 90.23% compared to head (b58a306) 90.09%.

❗ Current head b58a306 differs from pull request most recent head e3fb017. Consider uploading reports for the commit e3fb017 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
- Coverage   90.23%   90.09%   -0.14%     
==========================================
  Files         950      950              
  Lines       33766    34454     +688     
==========================================
+ Hits        30468    31042     +574     
- Misses       3298     3412     +114     
Files Changed Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/function/built_in_vector_functions.h 100.00% <ø> (ø)
...processor/operator/order_by/order_by_key_encoder.h 100.00% <ø> (ø)
src/include/storage/storage_structure/column.h 85.45% <ø> (ø)
...rc/include/storage/storage_structure/lists/lists.h 97.18% <ø> (ø)
...c/processor/operator/hash_join/join_hash_table.cpp 84.54% <0.00%> (-7.09%) ⬇️
src/storage/storage_structure/in_mem_file.cpp 41.99% <ø> (ø)
src/storage/store/column_chunk.cpp 73.60% <0.00%> (-2.85%) ⬇️
src/storage/store/node_column.cpp 78.28% <ø> (ø)
src/storage/store/struct_column_chunk.cpp 31.96% <0.00%> (-1.09%) ⬇️
... and 25 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to add more tests to improve test coverage

src/function/built_in_vector_functions.cpp Show resolved Hide resolved
src/processor/operator/order_by/order_by_key_encoder.cpp Outdated Show resolved Hide resolved
@Ashleyhx Ashleyhx force-pushed the ashleyhx/add-uint branch 4 times, most recently from ff22ee4 to 646810e Compare September 20, 2023 00:49
@Ashleyhx Ashleyhx marked this pull request as ready for review September 20, 2023 00:49
src/common/vector/value_vector.cpp Outdated Show resolved Hide resolved
@Ashleyhx Ashleyhx merged commit f59d9a8 into master Sep 20, 2023
9 checks passed
@Ashleyhx Ashleyhx deleted the ashleyhx/add-uint branch September 20, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants