Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor copy compilation #2043

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Refactor copy compilation #2043

merged 1 commit into from
Sep 17, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Sep 15, 2023

This PR breaks

LogicalCopyNode

as

LogicalCopyNode
LogicalScanFile

and

LogicalCopyRel

as

LogicalCopyRel
LogicalIndexScan
LogicalScanFile

We are going to reuse logical scan file for our direct scan feature

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 93.16% and project coverage change: -0.01% ⚠️

Comparison is base (9a8b6a4) 90.20% compared to head (ccea071) 90.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
- Coverage   90.20%   90.19%   -0.01%     
==========================================
  Files         937      945       +8     
  Lines       33429    33549     +120     
==========================================
+ Hits        30153    30261     +108     
- Misses       3276     3288      +12     
Files Changed Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
...e/binder/query/reading_clause/bound_match_clause.h 40.00% <ø> (-5.46%) ⬇️
src/include/catalog/property.h 96.00% <ø> (ø)
src/include/common/copier_config/copier_config.h 100.00% <ø> (ø)
src/include/parser/expression/parsed_expression.h 81.25% <ø> (ø)
...include/parser/query/reading_clause/match_clause.h 100.00% <ø> (ø)
...rc/include/planner/logical_plan/logical_operator.h 90.00% <ø> (ø)
...lude/planner/logical_plan/scan/logical_scan_node.h 100.00% <ø> (+20.00%) ⬆️
src/include/planner/query_planner.h 100.00% <ø> (ø)
.../include/processor/operator/persistent/copy_node.h 100.00% <ø> (ø)
... and 32 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/bind/bind_file_scan.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 2e460d6 into master Sep 17, 2023
11 checks passed
@andyfengHKU andyfengHKU deleted the refactor-copy-compilation branch September 17, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants