Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int8 supported functions #2030

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Add int8 supported functions #2030

merged 1 commit into from
Sep 14, 2023

Conversation

Ashleyhx
Copy link
Contributor

No description provided.

@Ashleyhx Ashleyhx marked this pull request as ready for review September 13, 2023 16:41
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 87.27% and project coverage change: +0.07% 🎉

Comparison is base (678055d) 90.08% compared to head (7d30255) 90.15%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
+ Coverage   90.08%   90.15%   +0.07%     
==========================================
  Files         919      919              
  Lines       33248    33364     +116     
==========================================
+ Hits        29950    30078     +128     
+ Misses       3298     3286      -12     
Files Changed Coverage Δ
src/include/function/built_in_vector_functions.h 100.00% <ø> (ø)
...c/processor/operator/hash_join/join_hash_table.cpp 91.62% <0.00%> (-1.96%) ⬇️
src/storage/copier/table_copy_utils.cpp 74.92% <0.00%> (-0.90%) ⬇️
src/include/function/hash/hash_functions.h 88.00% <50.00%> (-3.31%) ⬇️
src/function/vector_cast_functions.cpp 83.11% <78.94%> (-0.59%) ⬇️
src/include/function/cast/cast_functions.h 97.53% <93.75%> (+0.60%) ⬆️
src/common/types/types.cpp 92.32% <100.00%> (ø)
src/function/aggregate_function.cpp 82.85% <100.00%> (+1.60%) ⬆️
src/function/built_in_vector_functions.cpp 99.40% <100.00%> (+0.01%) ⬆️
src/function/comparison_functions.cpp 90.90% <100.00%> (+11.96%) ⬆️
... and 7 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashleyhx Ashleyhx force-pushed the ashleyhx/add-int8-func branch 3 times, most recently from 9ae24a2 to 0938ee9 Compare September 14, 2023 03:05
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can merge after the ci passes

@Ashleyhx Ashleyhx merged commit e6293de into master Sep 14, 2023
10 checks passed
@Ashleyhx Ashleyhx deleted the ashleyhx/add-int8-func branch September 14, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants