Transaction test rewrite #2029
Transaction test rewrite #2029
Conversation
hououou
dismissed
andyfengHKU’s stale review
the test framework has rewritten
add reloadDB
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2029 +/- ##
==========================================
- Coverage 90.15% 90.15% -0.01%
==========================================
Files 937 937
Lines 33362 33362
==========================================
- Hits 30078 30076 -2
- Misses 3284 3286 +2 ☔ View full report in Codecov by Sentry. |
| @@ -157,10 +164,24 @@ class DBTest : public BaseGraphTest { | |||
| initGraph(); | |||
| } | |||
|
|
|||
| inline void runTest(const std::vector<std::unique_ptr<TestStatement>>& statements) { | |||
| TestRunner::runTest(statements, *conn, databasePath); | |||
| inline void runTest(const std::vector<std::unique_ptr<TestStatement>>& statements, | |||
There was a problem hiding this comment.
put implementation in cpp.
Personally I'm not a big fun of using default parameters. Usually I just overload the function, i.e.
runTest(statements);
runTest(statements, checkpointWaitTimeout, connNames);
But you can decide this.
| @@ -31,6 +36,12 @@ struct TestGroup { | |||
| std::unordered_map<std::string, std::vector<std::unique_ptr<TestStatement>>> | |||
| testCasesStatementBlocks; | |||
| uint64_t bufferPoolSize = common::BufferPoolConstants::DEFAULT_BUFFER_POOL_SIZE_FOR_TESTING; | |||
| // for multiple connections | |||
| uint64_t checkpointWaitTimeout = | |||
There was a problem hiding this comment.
This is not really for multiple connections so move this line above the comment. Also @ray6080 should comment if this config will exist in the long term. I feel we might remove it at some point.
There was a problem hiding this comment.
I think this will exist for quite a long time.
I have read and agree to the terms under CLA.md.
I have made the following changes: