finish range literal [*] [*2] [*..] [*2..] [*..2] #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AEsir777
commented
Sep 12, 2023
•
AEsir777
commented
- finish range literal [*], [*2], [2..], [..2], [..]
- fix all the test cases
AEsir777
force-pushed
the
kebing-range-literal
branch
2 times, most recently
from
ede0886
to
bb88cd6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
+ Coverage 90.04% 90.08% +0.04%
==========================================
Files 918 919 +1
Lines 33125 33257 +132
==========================================
+ Hits 29826 29961 +135
+ Misses 3299 3296 -3
☔ View full report in Codecov by Sentry. |
AEsir777
force-pushed
the
kebing-range-literal
branch
3 times, most recently
from
b7c08db
to
1f7012b
Compare
AEsir777
changed the title
AEsir777
force-pushed
the
kebing-range-literal
branch
from
1f7012b
to
78894aa
Compare
andyfengHKU
approved these changes
Sep 13, 2023
| @@ -0,0 +1,121 @@ | |||
| -GROUP TinySnbReadTest | |||
There was a problem hiding this comment.
Move this test file to var_length_extend/
| -- | ||
|
|
||
| -CASE SingleUpperBound | ||
| -STATEMENT MATCH(a:person {fName: "Alice"})-[e:knows*..2]->(b:person) RETURN e; |
There was a problem hiding this comment.
Maybe just do a COUNT(*) here. I feel the ground truth is a bit long. Though this is up to u.
| Dan | ||
| -STATEMENT MATCH(a:person {fName: "Greg"})-[e:knows*..1]->(b:person) RETURN b.fName; | ||
| ---- 0 | ||
| # Different results from standard OpenCypher: 0 should be allowed |
AEsir777
force-pushed
the
kebing-range-literal
branch
from
78894aa
to
0728ee9
Compare
AEsir777
force-pushed
the
kebing-range-literal
branch
2 times, most recently
from
ab0c9e0
to
df15e71
Compare
andyfengHKU
approved these changes
Sep 13, 2023
| if (!recursiveInfo->upperBound.empty()) { | ||
| upperBound = TypeUtils::convertToUint32(recursiveInfo->upperBound.c_str()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove empty line.
You are now checking lowerBound <= limit then upperBound <= limit.
I guess you can just check lowerBound <= upperBound and then upperBound <= limit. This just comes to my mind that we didn't validate lowerBound <= upperBound.
AEsir777
force-pushed
the
kebing-range-literal
branch
from
df15e71
to
64c425e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.