Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitup value.h #2025

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Splitup value.h #2025

merged 1 commit into from
Sep 15, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 12, 2023

This file has the most lines compiled.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 75.65% and no project coverage change.

Comparison is base (5899d35) 90.14% compared to head (c1fd692) 90.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2025   +/-   ##
=======================================
  Coverage   90.14%   90.15%           
=======================================
  Files         934      938    +4     
  Lines       33364    33364           
=======================================
+ Hits        30077    30080    +3     
+ Misses       3287     3284    -3     
Files Changed Coverage Δ
src/c_api/connection.cpp 95.38% <ø> (ø)
src/c_api/flat_tuple.cpp 100.00% <ø> (ø)
src/c_api/prepared_statement.cpp 100.00% <ø> (ø)
src/c_api/value.cpp 86.95% <ø> (ø)
src/common/arrow/arrow_row_batch.cpp 55.33% <ø> (ø)
src/common/types/value/value.cpp 86.92% <ø> (ø)
src/common/vector/value_vector.cpp 94.61% <ø> (ø)
src/expression_evaluator/case_evaluator.cpp 81.72% <ø> (ø)
...xpression_evaluator/expression_evaluator_utils.cpp 100.00% <ø> (ø)
src/expression_evaluator/literal_evaluator.cpp 100.00% <ø> (ø)
... and 35 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku force-pushed the split-value-h branch 3 times, most recently from d20915b to 917491a Compare September 14, 2023 19:07
@Riolku Riolku marked this pull request as ready for review September 14, 2023 19:10
@Riolku Riolku marked this pull request as draft September 14, 2023 19:36
This file was recompiled the most in the entire project.
@Riolku Riolku marked this pull request as ready for review September 14, 2023 20:03
@Riolku Riolku merged commit 02e24ab into master Sep 15, 2023
9 of 10 checks passed
@Riolku Riolku deleted the split-value-h branch September 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants