Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases match3/4 and new feature "--" #2016

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

AEsir777
Copy link
Contributor

  • added tests match3/match4
  • added new feature MATCH (n) -- (b) RETURN ...
    • modify '.g4' files
    • add check for 'relDetails' to be nullptr

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /antlr4. and rebase&squash into 1 commits. Then we are ready to merge!

MATCH (a1)-[r:T]->(b2)
RETURN a1, r, b2;
---- error
Binder exception: Bind relationship r to relationship with same name is not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably where we are different from openCypher standard. Can u additionally comment in the test file as well. Something like # Different result so that we can quickly locate what are the statements to be fixed. Apply this change to match3&4

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (510d804) 90.03% compared to head (9fc716b) 90.03%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2016   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         903      903           
  Lines       32922    32923    +1     
=======================================
+ Hits        29641    29643    +2     
+ Misses       3281     3280    -1     
Files Changed Coverage Δ
src/parser/transform/transform_graph_pattern.cpp 93.18% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AEsir777 AEsir777 merged commit 134ced4 into kuzudb:master Sep 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants