Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocks counting in copying rel pipeline #2013

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Remove blocks counting in copying rel pipeline #2013

merged 1 commit into from
Sep 11, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Sep 10, 2023

Removes the unnecessary first pass counting of file blocks in Reader for csv files.

uw5, ldbc100 knows
before change after change
26888.49ms 20519.79 ms

src/processor/operator/persistent/reader.cpp Show resolved Hide resolved
src/processor/operator/persistent/reader.cpp Outdated Show resolved Hide resolved
src/processor/operator/persistent/reader.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 92.03% and project coverage change: +0.13% 🎉

Comparison is base (46f4039) 89.87% compared to head (c756eff) 90.01%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
+ Coverage   89.87%   90.01%   +0.13%     
==========================================
  Files         890      903      +13     
  Lines       32909    32922      +13     
==========================================
+ Hits        29578    29635      +57     
+ Misses       3331     3287      -44     
Files Changed Coverage Δ
src/include/common/data_chunk/sel_vector.h 100.00% <ø> (ø)
.../include/processor/operator/persistent/copy_node.h 100.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/include/storage/copier/table_copy_utils.h 100.00% <ø> (+50.00%) ⬆️
src/storage/copier/table_copy_utils.cpp 76.82% <ø> (+9.62%) ⬆️
...processor/operator/persistent/reader_functions.cpp 87.41% <87.41%> (ø)
src/include/processor/operator/persistent/reader.h 100.00% <100.00%> (ø)
...e/processor/operator/persistent/reader_functions.h 100.00% <100.00%> (ø)
...clude/processor/operator/persistent/reader_state.h 100.00% <100.00%> (+6.45%) ⬆️
src/processor/map/map_copy_from.cpp 100.00% <100.00%> (ø)
... and 4 more

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 510d804 into master Sep 11, 2023
10 checks passed
@ray6080 ray6080 deleted the node-group branch September 11, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants