Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction statement #2012

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Transaction statement #2012

merged 1 commit into from
Sep 11, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR deprecate transaction API connection.commit() by transaction statement connection.query("COMMIT")

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 96.48% and project coverage change: +0.02% 🎉

Comparison is base (46f4039) 89.87% compared to head (73a0215) 89.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   89.87%   89.90%   +0.02%     
==========================================
  Files         890      901      +11     
  Lines       32909    32990      +81     
==========================================
+ Hits        29578    29659      +81     
  Misses       3331     3331              
Files Changed Coverage Δ
src/c_api/connection.cpp 95.38% <ø> (-0.72%) ⬇️
src/catalog/catalog.cpp 100.00% <ø> (ø)
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/main/client_context.h 100.00% <ø> (ø)
src/include/main/connection.h 100.00% <ø> (ø)
src/include/main/prepared_statement.h 100.00% <ø> (ø)
src/include/parser/explain_statement.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
...rc/include/planner/logical_plan/logical_operator.h 90.00% <ø> (ø)
... and 37 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU marked this pull request as ready for review September 10, 2023 21:32
src/antlr4/Cypher.g4 Show resolved Hide resolved
src/include/processor/operator/transaction.h Show resolved Hide resolved
src/main/client_context.cpp Show resolved Hide resolved
src/main/connection.cpp Show resolved Hide resolved
src/main/prepared_statement.cpp Show resolved Hide resolved
src/transaction/transaction_context.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit e57b490 into master Sep 11, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the transaction-statement branch September 11, 2023 03:18
@ray6080 ray6080 changed the title [WIP] Transaction statement Transaction statement Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants