Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Commenting on Tables #2011

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Implement Commenting on Tables #2011

merged 1 commit into from
Sep 13, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 8, 2023

No description provided.

@Riolku Riolku force-pushed the add-table-comments branch 9 times, most recently from b270271 to 284f315 Compare September 11, 2023 20:52
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (bd69420) 90.01% compared to head (5f59f21) 90.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2011      +/-   ##
==========================================
+ Coverage   90.01%   90.05%   +0.04%     
==========================================
  Files         909      918       +9     
  Lines       32998    33125     +127     
==========================================
+ Hits        29702    29830     +128     
+ Misses       3296     3295       -1     
Files Changed Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/catalog/catalog_content.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
...rc/include/planner/logical_plan/logical_operator.h 90.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/include/processor/plan_mapper.h 100.00% <ø> (ø)
src/processor/processor.cpp 100.00% <ø> (ø)
src/binder/bind/bind_comment_on.cpp 100.00% <100.00%> (ø)
... and 26 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku force-pushed the add-table-comments branch 2 times, most recently from b1ae2d3 to 9df6356 Compare September 12, 2023 15:27
@Riolku
Copy link
Contributor Author

Riolku commented Sep 12, 2023

Since we are updating the on-disk storage format, is there anything special we need to do?

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on your first PR!
Don't forget to squash your commits before merging.

src/function/table_functions.cpp Show resolved Hide resolved
src/function/table_functions.cpp Outdated Show resolved Hide resolved
src/function/table_functions.cpp Outdated Show resolved Hide resolved
src/include/binder/bound_comment_on.h Outdated Show resolved Hide resolved
src/include/catalog/catalog_content.h Outdated Show resolved Hide resolved
src/include/function/table_functions.h Outdated Show resolved Hide resolved
src/include/processor/operator/comment_on.h Outdated Show resolved Hide resolved
@Riolku Riolku force-pushed the add-table-comments branch 5 times, most recently from af77306 to 597d834 Compare September 13, 2023 12:33
@Riolku Riolku marked this pull request as draft September 13, 2023 14:53
@Riolku Riolku marked this pull request as ready for review September 13, 2023 15:21
@Riolku Riolku merged commit defa82b into master Sep 13, 2023
10 checks passed
@Riolku Riolku deleted the add-table-comments branch September 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants