Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types_include.h #2008

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Remove types_include.h #2008

merged 1 commit into from
Sep 14, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 8, 2023

This convenience header was terrible for compilation.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (727840c) 90.15% compared to head (73cdf46) 90.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2008   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         934      934           
  Lines       33365    33364    -1     
=======================================
+ Hits        30079    30081    +2     
+ Misses       3286     3283    -3     
Files Changed Coverage Δ
src/common/types/types.cpp 92.32% <ø> (ø)
src/common/types/value.cpp 84.35% <ø> (ø)
src/include/binder/expression/expression.h 90.90% <ø> (ø)
src/include/common/copier_config/copier_config.h 100.00% <ø> (ø)
src/include/common/type_utils.h 96.96% <ø> (ø)
src/include/common/types/value.h 88.46% <ø> (ø)
src/include/function/cast/cast_functions.h 97.53% <ø> (ø)
src/include/function/hash/hash_functions.h 88.00% <ø> (ø)
src/include/function/udf_function.h 94.04% <ø> (ø)
...e/processor/operator/order_by/order_by_data_info.h 100.00% <ø> (ø)
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku force-pushed the remove-types-include branch 3 times, most recently from c081c94 to e7667dd Compare September 12, 2023 17:56
@Riolku Riolku marked this pull request as draft September 12, 2023 18:35
@Riolku Riolku marked this pull request as ready for review September 14, 2023 18:02
@Riolku Riolku merged commit 5899d35 into master Sep 14, 2023
10 checks passed
@Riolku Riolku deleted the remove-types-include branch September 14, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants