Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exception.h #2006

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Refactor exception.h #2006

merged 1 commit into from
Sep 14, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Sep 7, 2023

This was the most included header in the codebase. This refactoring should help compile times.

@Riolku Riolku force-pushed the refactor-exception-header branch 5 times, most recently from b3e867a to 1b5ffdb Compare September 7, 2023 21:18
@Riolku Riolku marked this pull request as draft September 7, 2023 21:29
@Riolku Riolku marked this pull request as ready for review September 7, 2023 21:48
@Riolku Riolku marked this pull request as draft September 7, 2023 22:24
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 73.91% and no project coverage change.

Comparison is base (417e86d) 90.09% compared to head (a31272a) 90.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2006   +/-   ##
=======================================
  Coverage   90.09%   90.10%           
=======================================
  Files         919      934   +15     
  Lines       33257    33258    +1     
=======================================
+ Hits        29964    29967    +3     
+ Misses       3293     3291    -2     
Files Changed Coverage Δ
src/binder/bind/bind_copy.cpp 86.41% <ø> (ø)
src/binder/bind/bind_create_macro.cpp 90.00% <ø> (ø)
src/binder/bind/bind_ddl.cpp 99.39% <ø> (ø)
src/binder/bind/bind_graph_pattern.cpp 95.62% <ø> (ø)
src/binder/bind/bind_projection_clause.cpp 93.38% <ø> (+0.04%) ⬆️
src/binder/bind/bind_standalone_call.cpp 100.00% <ø> (ø)
src/binder/bind/bind_updating_clause.cpp 96.18% <ø> (ø)
...inder/bind_expression/bind_function_expression.cpp 96.40% <ø> (-0.03%) ⬇️
...inder/bind_expression/bind_property_expression.cpp 87.14% <ø> (ø)
...inder/bind_expression/bind_variable_expression.cpp 100.00% <ø> (ø)
... and 113 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku marked this pull request as ready for review September 8, 2023 14:29
@Riolku Riolku force-pushed the refactor-exception-header branch 5 times, most recently from 7802c74 to 3abaf90 Compare September 12, 2023 20:34
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Let's rebase and get the benchmark CI passed before merge.

@mewim
Copy link
Collaborator

mewim commented Sep 14, 2023

Please make sure that the header merge script still works (you can trigger https://github.com/kuzudb/kuzu/actions/workflows/linux-precompiled-bin-workflow.yml and test the generated lib + header) before merging.

@Riolku
Copy link
Contributor Author

Riolku commented Sep 14, 2023

Please make sure that the header merge script still works (you can trigger https://github.com/kuzudb/kuzu/actions/workflows/linux-precompiled-bin-workflow.yml and test the generated lib + header) before merging.

@mewim how do I test the generated lib + header?

This was the most included header in the codebase. This refactoring should help compile times.
@mewim
Copy link
Collaborator

mewim commented Sep 14, 2023

Please make sure that the header merge script still works (you can trigger https://github.com/kuzudb/kuzu/actions/workflows/linux-precompiled-bin-workflow.yml and test the generated lib + header) before merging.

@mewim how do I test the generated lib + header?

You can follow the example in the documentation: https://kuzudb.com/docusaurus/getting-started/cpp

The dataset used is under https://github.com/kuzudb/kuzu/tree/master/dataset/demo-db/csv

@Riolku
Copy link
Contributor Author

Riolku commented Sep 14, 2023

Tested against the example linked, works. Benchmark is now passing. I'm rerunning MSVC that hit a timeout of some kind while testing, and will merge after that.

@Riolku Riolku merged commit 727840c into master Sep 14, 2023
9 of 10 checks passed
@Riolku Riolku deleted the refactor-exception-header branch September 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants