Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copy morsel size back to DEFAULT_VECTOR_CAPACITY #1992

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

acquamarin
Copy link
Collaborator

Change morsel size back to DEFAULT_VECTOR_CAPACITY

src/binder/bind/bind_copy.cpp Outdated Show resolved Hide resolved
src/storage/copier/reader_state.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.41% ⚠️

Comparison is base (bf7414f) 90.27% compared to head (6ed048c) 89.86%.

❗ Current head 6ed048c differs from pull request most recent head 37191a7. Consider uploading reports for the commit 37191a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
- Coverage   90.27%   89.86%   -0.41%     
==========================================
  Files         883      882       -1     
  Lines       32398    32662     +264     
==========================================
+ Hits        29247    29353     +106     
- Misses       3151     3309     +158     
Files Changed Coverage Δ
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
.../include/processor/operator/persistent/copy_node.h 100.00% <ø> (ø)
src/include/storage/copier/reader_state.h 92.30% <ø> (ø)
src/binder/bind/bind_copy.cpp 89.52% <100.00%> (+0.05%) ⬆️
src/common/vector/value_vector.cpp 98.12% <100.00%> (+0.02%) ⬆️
src/include/binder/copy/bound_copy_from.h 100.00% <100.00%> (ø)
...lude/planner/logical_plan/copy/logical_copy_from.h 100.00% <100.00%> (ø)
src/include/processor/operator/persistent/reader.h 100.00% <100.00%> (ø)
src/planner/plan/plan_copy.cpp 100.00% <100.00%> (ø)
src/processor/map/map_copy_from.cpp 93.75% <100.00%> (-6.25%) ⬇️
... and 5 more

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/binder/bind/bind_copy.cpp Outdated Show resolved Hide resolved
src/storage/store/rel_table.cpp Show resolved Hide resolved
src/storage/copier/reader_state.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 520d496 into master Sep 6, 2023
10 checks passed
@acquamarin acquamarin deleted the copy-morsel-size branch September 6, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants