configure CI workflow for Ubuntu 20.04 LTS #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewim
reviewed
Sep 5, 2023
| - name: Java test | ||
| run: CC=gcc CXX=g++ make javatest NUM_THREADS=32 | ||
|
|
||
| - name: Generate coverage report |
There was a problem hiding this comment.
You don't need to generate coverage report
mewim
approved these changes
Sep 5, 2023
mewim
reviewed
Sep 5, 2023
| working-directory: tools/nodejs_api | ||
|
|
||
| - name: Test with coverage | ||
| run: CC=gcc CXX=g++ make lcov NUM_THREADS=32 |
There was a problem hiding this comment.
GitHub-hosted machines have much fewer cores, please check this or use $(nproc) to get core counts dynamically.
Riolku
pushed a commit
that referenced
this pull request
Sep 7, 2023
Co-authored-by: Russell Liu <russell.liu@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.