Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement csv reader #1988

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Implement csv reader #1988

merged 1 commit into from
Sep 7, 2023

Conversation

acquamarin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 87.61% and project coverage change: -0.42% ⚠️

Comparison is base (b71fe50) 90.29% compared to head (e9fe87c) 89.87%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
- Coverage   90.29%   89.87%   -0.42%     
==========================================
  Files         883      884       +1     
  Lines       32411    32816     +405     
==========================================
+ Hits        29265    29495     +230     
- Misses       3146     3321     +175     
Files Changed Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/data_chunk/sel_vector.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 72.72% <ø> (ø)
src/storage/copier/struct_column_chunk.cpp 32.75% <0.00%> (-48.73%) ⬇️
src/storage/copier/var_list_column_chunk.cpp 80.72% <50.00%> (-13.26%) ⬇️
src/common/vector/value_vector.cpp 94.52% <68.00%> (-3.61%) ⬇️
src/processor/operator/persistent/copy_node.cpp 92.30% <75.00%> (-2.82%) ⬇️
src/include/common/exception.h 73.91% <80.00%> (+1.18%) ⬆️
src/processor/operator/persistent/csv_reader.cpp 87.32% <87.32%> (ø)
... and 14 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we're going to revert changes on ValueVector capacity. Just push my comments here for a few files. Will continue later after the changes.

src/catalog/table_schema.cpp Outdated Show resolved Hide resolved
src/common/vector/value_vector.cpp Show resolved Hide resolved
test/test_files/copy/copy_special_char.test Show resolved Hide resolved
test/test_files/copy/copy_to.test Show resolved Hide resolved
test/test_files/copy/copy_to.test Outdated Show resolved Hide resolved
src/storage/copier/node_group.cpp Show resolved Hide resolved
src/include/processor/operator/persistent/csv_reader.h Outdated Show resolved Hide resolved
src/planner/operator/copy/logical_copy_from.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 9fe713e into master Sep 7, 2023
10 checks passed
@acquamarin acquamarin deleted the csv-reader-node branch September 7, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants