Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate rel bug #1987

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Fix aggregate rel bug #1987

merged 1 commit into from
Sep 3, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR fix a bug with aggregating rel and add more tests

It also adds an optimization to rewrite COUNT(node/rel) as COUNT(node/rel._ID)

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 84.00% and project coverage change: +0.03% 🎉

Comparison is base (bc16021) 89.81% compared to head (b061b9a) 89.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
+ Coverage   89.81%   89.85%   +0.03%     
==========================================
  Files         878      881       +3     
  Lines       32550    32560      +10     
==========================================
+ Hits        29235    29256      +21     
+ Misses       3315     3304      -11     
Files Changed Coverage Δ
src/binder/bind/bind_updating_clause.cpp 96.18% <ø> (ø)
...inder/bind_expression/bind_property_expression.cpp 87.14% <ø> (ø)
src/binder/expression/expression.cpp 88.88% <ø> (+5.91%) ⬆️
src/binder/expression/function_expression.cpp 100.00% <ø> (ø)
src/include/binder/expression/expression.h 90.00% <ø> (-1.31%) ⬇️
.../function/aggregate/built_in_aggregate_functions.h 100.00% <ø> (ø)
src/include/function/aggregate/count.h 100.00% <ø> (+33.33%) ⬆️
src/include/function/function_definition.h 100.00% <ø> (ø)
src/include/function/vector_functions.h 100.00% <ø> (ø)
src/include/planner/logical_plan/schema.h 100.00% <ø> (ø)
... and 9 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 3c2086b into master Sep 3, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the fix-agg-rel-bug branch September 3, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants