Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader compilation refactor #1985

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Reader compilation refactor #1985

merged 1 commit into from
Sep 2, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 97.31% and no project coverage change.

Comparison is base (8dd9ba4) 89.81% compared to head (9d4ce42) 89.81%.

❗ Current head 9d4ce42 differs from pull request most recent head cb81646. Consider uploading reports for the commit cb81646 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1985   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         876      878    +2     
  Lines       32553    32550    -3     
=======================================
- Hits        29236    29235    -1     
+ Misses       3317     3315    -2     
Files Changed Coverage Δ
src/common/copier_config/copier_config.cpp 40.00% <ø> (-32.73%) ⬇️
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
src/include/processor/physical_plan.h 100.00% <ø> (ø)
src/processor/map/map_copy_from.cpp 92.59% <92.59%> (ø)
src/binder/bind/bind_copy.cpp 89.52% <93.54%> (+1.48%) ⬆️
src/include/binder/copy/bound_copy_from.h 100.00% <100.00%> (ø)
src/include/binder/copy/bound_copy_to.h 100.00% <100.00%> (ø)
src/include/common/copier_config/copier_config.h 100.00% <100.00%> (ø)
...lude/planner/logical_plan/copy/logical_copy_from.h 100.00% <100.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/processor/map/map_copy_from.cpp Outdated Show resolved Hide resolved
src/processor/map/map_copy.cpp Outdated Show resolved Hide resolved
src/include/planner/logical_plan/copy/logical_copy_from.h Outdated Show resolved Hide resolved
src/include/binder/copy/bound_copy_from.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit bc16021 into master Sep 2, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the node-copy-refactor branch September 2, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants