Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #1959 #1974

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Implement #1959 #1974

merged 1 commit into from
Aug 29, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Aug 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.03% ⚠️

Comparison is base (e1cfe67) 89.68% compared to head (05e067a) 89.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
- Coverage   89.68%   89.65%   -0.03%     
==========================================
  Files         877      877              
  Lines       32328    32319       -9     
==========================================
- Hits        28994    28977      -17     
- Misses       3334     3342       +8     
Files Changed Coverage Δ
tools/python_api/src_cpp/include/py_connection.h 100.00% <ø> (ø)
tools/python_api/src_cpp/py_connection.cpp 89.58% <85.71%> (-0.62%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit 58ee272 into master Aug 29, 2023
10 checks passed
@mewim mewim deleted the fix-1959 branch August 29, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants