Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor order by compilation #1971

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Refactor order by compilation #1971

merged 1 commit into from
Aug 29, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (440eb0a) 89.66% compared to head (7267f59) 89.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1971      +/-   ##
==========================================
+ Coverage   89.66%   89.69%   +0.02%     
==========================================
  Files         876      877       +1     
  Lines       32337    32328       -9     
==========================================
- Hits        28996    28995       -1     
+ Misses       3341     3333       -8     
Files Changed Coverage Δ
...processor/operator/order_by/order_by_key_encoder.h 100.00% <ø> (ø)
src/include/processor/operator/order_by/order_by.h 100.00% <100.00%> (ø)
...e/processor/operator/order_by/order_by_data_info.h 100.00% <100.00%> (ø)
...c/include/processor/operator/order_by/sort_state.h 100.00% <100.00%> (ø)
src/include/processor/operator/order_by/top_k.h 100.00% <100.00%> (ø)
...nclude/processor/operator/order_by/top_k_scanner.h 100.00% <100.00%> (ø)
src/processor/map/map_order_by.cpp 100.00% <100.00%> (ø)
src/processor/operator/order_by/order_by.cpp 100.00% <100.00%> (ø)
...ocessor/operator/order_by/order_by_key_encoder.cpp 83.33% <100.00%> (ø)
src/processor/operator/order_by/sort_state.cpp 100.00% <100.00%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/processor/operator/order_by/sort_state.h Outdated Show resolved Hide resolved
src/include/processor/operator/order_by/top_k.h Outdated Show resolved Hide resolved
src/include/processor/operator/order_by/top_k.h Outdated Show resolved Hide resolved
src/processor/map/map_order_by.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit e1cfe67 into master Aug 29, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the order-by-compilation branch August 29, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants