Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove currIdx from DataChunkState #1966

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove currIdx from DataChunkState #1966

merged 1 commit into from
Aug 29, 2023

Conversation

andyfengHKU
Copy link
Contributor

We take another step in solving #744. This time we remove currIdx and replace with a FactorizationState.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: -0.03% ⚠️

Comparison is base (58ee272) 89.68% compared to head (4447f9f) 89.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
- Coverage   89.68%   89.65%   -0.03%     
==========================================
  Files         877      877              
  Lines       32319    32316       -3     
==========================================
- Hits        28984    28974      -10     
- Misses       3335     3342       +7     
Files Changed Coverage Δ
src/common/data_chunk/data_chunk_state.cpp 100.00% <ø> (ø)
...cessor/operator/aggregate/aggregate_hash_table.cpp 82.73% <ø> (-0.04%) ⬇️
src/storage/storage_structure/column.cpp 61.53% <ø> (-0.18%) ⬇️
...age/storage_structure/lists/lists_update_store.cpp 96.98% <0.00%> (-0.02%) ⬇️
...rc/storage/storage_structure/storage_structure.cpp 96.61% <ø> (-0.12%) ⬇️
src/storage/store/node_column.cpp 77.24% <ø> (-1.99%) ⬇️
src/include/common/data_chunk/data_chunk_state.h 100.00% <100.00%> (ø)
src/include/processor/operator/flatten.h 100.00% <100.00%> (ø)
...ude/processor/operator/hash_join/hash_join_build.h 100.00% <100.00%> (ø)
src/processor/map/map_hash_join.cpp 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/common/data_chunk/data_chunk_state.h Outdated Show resolved Hide resolved
test/transaction/transaction_test.cpp Outdated Show resolved Hide resolved
src/include/common/data_chunk/data_chunk_state.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 738a662 into master Aug 29, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the currIdx-rework branch August 29, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants