Implement top-k optimization #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
- Coverage 89.75% 89.48% -0.28%
==========================================
Files 868 881 +13
Lines 32032 32348 +316
==========================================
+ Hits 28750 28946 +196
- Misses 3282 3402 +120
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Aug 26, 2023
| using vector_select_comparison_func = | ||
| std::function<bool(common::ValueVector&, common::ValueVector&, common::SelectionVector&)>; | ||
|
|
||
| struct TopKScanState { |
There was a problem hiding this comment.
Leave a TODO for me to move this into mapper
There was a problem hiding this comment.
I don't think we can move the initialization to mapper.
We need have access to the sortedKeyBlock. If the sorting hasn't started, we don't have access to the sortedKeyBlock.
acquamarin
force-pushed
the
top-k
branch
2 times, most recently
from
bfc463b
to
a7089cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the optimization for top-k queries.
Sample top-k queries:
MATCH (comment:Comment) return comment.length,comment.creationDate ORDER BY comment.length, comment.creationDate LIMIT 5We merge the order by and limit operator together.
Instead of accumulating all tuples, we do local sort and only keep the top-k tuples in each thread.
Performance number:
https://docs.google.com/spreadsheets/d/1K53Yz8KMuvrFfXbyoPyULhWt9nSBEUI6W4WdMWirODM/edit#gid=1649459535