Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename keys in agg hash table #1957

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Rename keys in agg hash table #1957

merged 1 commit into from
Aug 25, 2023

Conversation

andyfengHKU
Copy link
Contributor

Rename groupByXXXHashKeys -> XXXKeys.

Passing in a leading dataChunk state to remove code like

groupByUnFlatHashKeyVectors.empty() ? 1: groupByUnFlatHashKeyVectors[0]->state->selVector->selectedSize.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 90.24% and project coverage change: -0.01% ⚠️

Comparison is base (9399be0) 89.67% compared to head (8d40ddd) 89.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   89.67%   89.67%   -0.01%     
==========================================
  Files         870      870              
  Lines       32019    32013       -6     
==========================================
- Hits        28714    28708       -6     
  Misses       3305     3305              
Files Changed Coverage Δ
...rocessor/operator/aggregate/aggregate_hash_table.h 81.81% <ø> (ø)
...lude/processor/operator/aggregate/hash_aggregate.h 100.00% <ø> (ø)
...cessor/operator/aggregate/aggregate_hash_table.cpp 82.76% <89.87%> (-0.26%) ⬇️
...rc/processor/operator/aggregate/hash_aggregate.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit dc4266a into master Aug 25, 2023
10 checks passed
@andyfengHKU andyfengHKU deleted the rework-agg-hash-table branch August 25, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants